Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make settings available from system env #269

Closed
wants to merge 3 commits into from

Conversation

jonaskahn
Copy link

@jonaskahn jonaskahn commented Dec 20, 2024

This PR just make settings now ability get from system env config.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jonaskahn
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 20, 2024
@yasyf
Copy link

yasyf commented Dec 20, 2024

pydantic-settings will already do this for you, pretty sure

@jonaskahn
Copy link
Author

Oh, I see. Let me check it.

@andersfylling
Copy link

Personally I'd prefer less dependencies. Adjusting configuration values is very common to do via the terminal:

SURYA_IMAGE_DPI=128 python script.py

You see this for other projects like Tika, tesseract, etc. So I'd welcome this change rather than forcing it to be done via some python abstraction.

@jonaskahn
Copy link
Author

Personally I'd prefer less dependencies. Adjusting configuration values is very common to do via the terminal:

SURYA_IMAGE_DPI=128 python script.py

You see this for other projects like Tika, tesseract, etc. So I'd welcome this change rather than forcing it to be done via some python abstraction.

Totally agreed, but I close it as respect the author's idea.

@jonaskahn jonaskahn closed this Jan 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants