Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertaisarvio peer review #1

Open
Qwecu opened this issue Nov 27, 2020 · 0 comments
Open

Vertaisarvio peer review #1

Qwecu opened this issue Nov 27, 2020 · 0 comments

Comments

@Qwecu
Copy link

Qwecu commented Nov 27, 2020

Files fetched November 26th about 20:45

This project uses several libraries that are unfamiliar to me - I recognise Box2D by name but have never used it myself. Interesting to see some code in action :)

Some "magic strings" are used for directions in the MainGame class: maybe better to replace them with an enum? That would ease refactoring and eliminate typo bugs.

Overall, being unfamiliar with the libraries, I woud like to see more comments in the code so it would be easier to undesrstand. Also the algorithm is tew to me, so some verbal explanation would be nice.

On one run, I got an "Index out of bounds" exception.

It seems that the code includes some textures that didn't get dowloaded on my computer. Are you sure that they are properly included in the project?

It is nice that the project has real graphics and not just the algorithm, this is certainly easy to develop into a real game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant