feat: expose shrinkWrap of CustomScrollView #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
reviewed
Aug 20, 2024
| @@ -76,6 +77,12 @@ class InfiniteList extends StatelessWidget { | |||
| /// {@endtemplate} | |||
| final bool reverse; | |||
|
|
|||
| /// {@template shrinkWrap} | |||
There was a problem hiding this comment.
Nit: If the @template is not being used elsewhere in a @macro we should remove the @template.
Comment on lines
+82
to
+83
| /// should be determined by the contents being viewed. | ||
| /// {@endtemplate} |
There was a problem hiding this comment.
Nit: consider referencing the property that the value is proxying to.
Suggested change
| /// should be determined by the contents being viewed. | |
| /// {@endtemplate} | |
| /// should be determined by the contents being viewed. | |
| /// | |
| /// See also: | |
| /// | |
| /// * [CustomScrollView.shrinkWrap], for more details about this flag. |
There was a problem hiding this comment.
Are you waiting for my response?
I not sure how to "add some tests to ensure the property gets proxied into CustomScrollView and ensure false is the default?"
There was a problem hiding this comment.
Hi @limcheekin sorry for the late reply, you can try having a look at a recent PR: #76, to get inspired on how to test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
I exposed the
shrinkWrapoption of theCustomScrollViewwidget to support the top alignment of list items. Please see section "3. Aligning Chat Messages to the Top" of the article at https://medium.com/@ximya/tips-and-tricks-for-implementing-a-successful-chat-ui-in-flutter-190cd81bdc64.If you think the changes are unnecessary, please let me know the alternative solution.
Type of Change