feat(flame_behaviors): add priority and key to the constructor
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfenrain
changed the title
priority and key to the constructorpriority and key to the constructor
alestiago
reviewed
Jan 11, 2024
| class _TestBehavior extends DraggableBehavior {} | ||
|
|
||
| void main() { | ||
| group('$DraggableBehavior', () { |
There was a problem hiding this comment.
Should we add some tests that specify these "new" arguments?
There was a problem hiding this comment.
We dont control them, it's just passing them through from Flame.
There was a problem hiding this comment.
Even if they're from Flame, if we do not specify "super." they can't be passed, right? If we revert the change and keep the tests as they are now, all test will still pass?
alestiago
approved these changes
Jan 11, 2024
wolfenrain
deleted the
feat(flame_behaviors)/add-`priority`-and-`key`-to-the-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Add the flame's priority and key arguments.
Type of Change