From d312653525b697201501fcace8da72a40069b72e Mon Sep 17 00:00:00 2001 From: vgvbot Date: Mon, 6 Nov 2023 14:20:22 +0000 Subject: [PATCH 1/5] feat: CHANGELOG for Nov 06, 2023 --- 2023/06-11-23.md | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 2023/06-11-23.md diff --git a/2023/06-11-23.md b/2023/06-11-23.md new file mode 100644 index 0000000..951ce13 --- /dev/null +++ b/2023/06-11-23.md @@ -0,0 +1,39 @@ +# Very Good Changelog (11-06-2023) + +TODO: Someone should write a nice description for this CHANGELOG + +## dart_frog +- feat(dart_frog_cli): add host option to `dev` ([@renancaraujo](https://github.com/renancaraujo)) + - https://github.com/VeryGoodOpenSource/dart_frog/pull/1114 +- feat: Support reuse of nested router ([@davidmartos96](https://github.com/davidmartos96)) + - https://github.com/VeryGoodOpenSource/dart_frog/pull/393 + +## very_good_infinite_list +- docs: update readme option docs ([@renancaraujo](https://github.com/renancaraujo)) + - https://github.com/VeryGoodOpenSource/very_good_infinite_list/pull/59 + +## very_good_cli +- chore: v0.17.1 ([@alestiago](https://github.com/alestiago)) + - https://github.com/VeryGoodOpenSource/very_good_cli/pull/872 + +## very_good_core +- test: tested pre_gen hook ([@alestiago](https://github.com/alestiago)) + - https://github.com/VeryGoodOpenSource/very_good_core/pull/305 +- ci: update generation workflow reviewers ([@renancaraujo](https://github.com/renancaraujo)) + - https://github.com/VeryGoodOpenSource/very_good_core/pull/303 + +## very_good_coverage +- fix: min_coverage parsing with default to 100 ([@kelvinwieth](https://github.com/kelvinwieth)) + - https://github.com/VeryGoodOpenSource/very_good_coverage/pull/290 + +## very_good_workflows +- feat: allow run skipped tests ([@kelvinwieth](https://github.com/kelvinwieth)) + - https://github.com/VeryGoodOpenSource/very_good_workflows/pull/152 + +## very_good_flame_game +- feat: add macOS platform support ([@mxknt](https://github.com/mxknt)) + - https://github.com/VeryGoodOpenSource/very_good_flame_game/pull/125 + +## cli_completion +- chore: fix issue tracker on pubspec ([@renancaraujo](https://github.com/renancaraujo)) + - https://github.com/VeryGoodOpenSource/cli_completion/pull/82 From ba6a06cf8d334102f24a859286b1a117f11b6547 Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 6 Nov 2023 08:33:01 -0600 Subject: [PATCH 2/5] formatting and attepting to fix pr workflow --- .github/workflows/validate_pr.yaml | 8 +------- .vscode/cspell.json | 1 + 2023/06-11-23.md | 28 ++++++++++++++++++---------- 2023/30-10-23.md | 2 -- 4 files changed, 20 insertions(+), 19 deletions(-) diff --git a/.github/workflows/validate_pr.yaml b/.github/workflows/validate_pr.yaml index fdbcac4..ec41820 100644 --- a/.github/workflows/validate_pr.yaml +++ b/.github/workflows/validate_pr.yaml @@ -1,12 +1,6 @@ name: "Validate PR" -on: - pull_request_target: - types: - - opened - - reopened - - edited - - synchronize +on: pull_request jobs: valdiate_pr_title: diff --git a/.vscode/cspell.json b/.vscode/cspell.json index d4a96d7..5f99f2b 100644 --- a/.vscode/cspell.json +++ b/.vscode/cspell.json @@ -27,6 +27,7 @@ "Fluttercon", "formz", "gabrielrozendo", + "gonzalogauto", "gradlew", "Hadley", "Henrique", diff --git a/2023/06-11-23.md b/2023/06-11-23.md index 951ce13..4009cc4 100644 --- a/2023/06-11-23.md +++ b/2023/06-11-23.md @@ -3,37 +3,45 @@ TODO: Someone should write a nice description for this CHANGELOG ## dart_frog + - feat(dart_frog_cli): add host option to `dev` ([@renancaraujo](https://github.com/renancaraujo)) - - https://github.com/VeryGoodOpenSource/dart_frog/pull/1114 + - https://github.com/VeryGoodOpenSource/dart_frog/pull/1114 - feat: Support reuse of nested router ([@davidmartos96](https://github.com/davidmartos96)) - - https://github.com/VeryGoodOpenSource/dart_frog/pull/393 + - https://github.com/VeryGoodOpenSource/dart_frog/pull/393 ## very_good_infinite_list + - docs: update readme option docs ([@renancaraujo](https://github.com/renancaraujo)) - - https://github.com/VeryGoodOpenSource/very_good_infinite_list/pull/59 + - https://github.com/VeryGoodOpenSource/very_good_infinite_list/pull/59 ## very_good_cli + - chore: v0.17.1 ([@alestiago](https://github.com/alestiago)) - - https://github.com/VeryGoodOpenSource/very_good_cli/pull/872 + - https://github.com/VeryGoodOpenSource/very_good_cli/pull/872 ## very_good_core + - test: tested pre_gen hook ([@alestiago](https://github.com/alestiago)) - - https://github.com/VeryGoodOpenSource/very_good_core/pull/305 + - https://github.com/VeryGoodOpenSource/very_good_core/pull/305 - ci: update generation workflow reviewers ([@renancaraujo](https://github.com/renancaraujo)) - - https://github.com/VeryGoodOpenSource/very_good_core/pull/303 + - https://github.com/VeryGoodOpenSource/very_good_core/pull/303 ## very_good_coverage + - fix: min_coverage parsing with default to 100 ([@kelvinwieth](https://github.com/kelvinwieth)) - - https://github.com/VeryGoodOpenSource/very_good_coverage/pull/290 + - https://github.com/VeryGoodOpenSource/very_good_coverage/pull/290 ## very_good_workflows + - feat: allow run skipped tests ([@kelvinwieth](https://github.com/kelvinwieth)) - - https://github.com/VeryGoodOpenSource/very_good_workflows/pull/152 + - https://github.com/VeryGoodOpenSource/very_good_workflows/pull/152 ## very_good_flame_game + - feat: add macOS platform support ([@mxknt](https://github.com/mxknt)) - - https://github.com/VeryGoodOpenSource/very_good_flame_game/pull/125 + - https://github.com/VeryGoodOpenSource/very_good_flame_game/pull/125 ## cli_completion + - chore: fix issue tracker on pubspec ([@renancaraujo](https://github.com/renancaraujo)) - - https://github.com/VeryGoodOpenSource/cli_completion/pull/82 + - https://github.com/VeryGoodOpenSource/cli_completion/pull/82 diff --git a/2023/30-10-23.md b/2023/30-10-23.md index 2a557b4..8ff07f0 100644 --- a/2023/30-10-23.md +++ b/2023/30-10-23.md @@ -11,9 +11,7 @@ Some CLI fixes and updates - fix: ignore empty allowed or forbidden ([@alestiago](https://github.com/alestiago)) - https://github.com/VeryGoodOpenSource/very_good_cli/pull/868 - ## very_good_core - fix(Android): change launchMode on Android to singleTask ([@gonzalogauto](https://github.com/gonzalogauto)) - https://github.com/VeryGoodOpenSource/very_good_core/pull/297 - From 01a89052a8c857092a047654321c27b9ad58b4f7 Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 6 Nov 2023 08:40:41 -0600 Subject: [PATCH 3/5] attempt to fix changelog check --- .github/workflows/validate_pr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate_pr.yaml b/.github/workflows/validate_pr.yaml index ec41820..8bc76e8 100644 --- a/.github/workflows/validate_pr.yaml +++ b/.github/workflows/validate_pr.yaml @@ -27,7 +27,7 @@ jobs: steps: - name: "Check for TODO statement" run: | - [ $(grep "TODO: Someone should write a nice description for this CHANGELOG" **/*.md | wc -l) = 0 ] + if [ $(grep "TODO: Someone should write a nice description for this CHANGELOG" **/*.md | wc -l) != 0 ]; then exit 1; fi validate_spelling: name: Validate Spelling runs-on: ubuntu-latest From 192fdd6cad1d325f23f6a19c90c0bcae8b7c1723 Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 6 Nov 2023 08:42:07 -0600 Subject: [PATCH 4/5] actually checkout the files facepalm --- .github/workflows/validate_pr.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/validate_pr.yaml b/.github/workflows/validate_pr.yaml index 8bc76e8..c1d1915 100644 --- a/.github/workflows/validate_pr.yaml +++ b/.github/workflows/validate_pr.yaml @@ -25,6 +25,8 @@ jobs: name: Validate Changelog Description runs-on: ubuntu-latest steps: + - name: Checkout Repo + uses: actions/checkout@v4 - name: "Check for TODO statement" run: | if [ $(grep "TODO: Someone should write a nice description for this CHANGELOG" **/*.md | wc -l) != 0 ]; then exit 1; fi From 57f001824c374a239538208221d7e4f5f50a59bc Mon Sep 17 00:00:00 2001 From: Tom Arra Date: Mon, 6 Nov 2023 08:43:49 -0600 Subject: [PATCH 5/5] update description and spelling --- .vscode/cspell.json | 2 ++ 2023/06-11-23.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.vscode/cspell.json b/.vscode/cspell.json index 5f99f2b..f46980e 100644 --- a/.vscode/cspell.json +++ b/.vscode/cspell.json @@ -15,6 +15,7 @@ "cgutierr", "chanan", "codeowner", + "davidmartos", "depandabot", "devserver", "dezsocsete", @@ -54,6 +55,7 @@ "mocktail", "mtwichel", "Muhammed-Ayad", + "mxknt", "ndelanou", "pablojimpas", "pana", diff --git a/2023/06-11-23.md b/2023/06-11-23.md index 4009cc4..37ab3f2 100644 --- a/2023/06-11-23.md +++ b/2023/06-11-23.md @@ -1,6 +1,6 @@ # Very Good Changelog (11-06-2023) -TODO: Someone should write a nice description for this CHANGELOG +Release Very Good CLI 0.17.1 and some minor fixes across the packages. ## dart_frog