Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set favicon.ico head entry if custom favicon.ico is not present in static directory #439

Open
bkis opened this issue Oct 24, 2024 · 0 comments
Open

Only set favicon.ico head entry if custom favicon.ico is not present in static directory #439

bkis opened this issue Oct 24, 2024 · 0 comments
Assignees
@bkis
Labels
UI/UX Do not press this button!

Comments

@bkis
Copy link
Member

bkis commented Oct 24, 2024

Having an entry for a favicon.ico at / in HTML <head> seems to keep the browser from trying to fetch the one that is available at / on it's own. So we should only set this entry if:

  1. the custom favicon.ico is not present (the default one from static/ should be used)
  2. the client base path is / (for sub-paths, we should still set the <head> entry!)
@bkis bkis added the UI/UX Do not press this button! label Oct 24, 2024
@bkis bkis self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkis bkis

Labels
UI/UX Do not press this button!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkis