Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build with libc++ 16 #979

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Unbreak build with libc++ 16 #979

merged 1 commit into from
Oct 11, 2023

Conversation

jbeich
Copy link

@jbeich jbeich commented Oct 11, 2023

Upcoming FreeBSD 14.0 ships with libc++ 16. However, libc++ 17 isn't affected due to header bootlegging:

In file included from ../src/drm.cpp:21:
In file included from ../src/drm.hpp:11:
In file included from /usr/include/c++/v1/span:600:
In file included from /usr/include/c++/v1/functional:526:
In file included from /usr/include/c++/v1/__functional/boyer_moore_searcher.h:27:
In file included from /usr/include/c++/v1/vector:321:
In file included from /usr/include/c++/v1/__format/formatter_bool.h:20:
In file included from /usr/include/c++/v1/__format/formatter_integral.h:32:
In file included from /usr/include/c++/v1/locale:202:
In file included from /usr/include/c++/v1/__locale:21:
/usr/include/c++/v1/mutex:12:2: error: 1
   12 | #error bootlegging check
      |  ^

Copy link
Collaborator

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jbeich
Copy link
Author

jbeich commented Oct 11, 2023

../src/reshade_effect_manager.cpp:17:10: fatal error: stb_image_resize.h: No such file or directory
   17 | #include <stb_image_resize.h>
      |          ^~~~~~~~~~~~~~~~~~~~

False negative due to CI relying on a moving target:

revision = master

@emersion
Copy link
Collaborator

Fixed in #981

In file included from src/drm.cpp:21:
In file included from src/drm.hpp:89:
src/rendervulkan.hpp:774:7: error: no type named 'mutex' in namespace 'std'
        std::mutex m_pipelineMutex;
        ~~~~~^
@emersion emersion merged commit dd851e5 into ValveSoftware:master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants