Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to add profile photo #32

Open
mirfilip opened this issue Mar 26, 2016 · 4 comments
Open

Inability to add profile photo #32

mirfilip opened this issue Mar 26, 2016 · 4 comments
Labels

Comments

@mirfilip
Copy link

this is a copy of the original issue

Hi,
going to Profile & Status there seem to be an ability to add a profile photo. There is an upload photo button when you click on the photo placeholder. Then "To upload media, drag and drop the file into the WhatsApp Web window." dialog appears. When you try to drag & drop the photo there - nothing happens.

I found out the issues is somewhat mentioned in the readme:

Media uploading is supported when dragging the image/video file into the app's window. Uploading using the upload button is currently not supported, since WKWebView provides no easy mechanism for using tags.

Still, drag & drop doesn't seem to work there.

@c-o-m-m-a-n-d-e-r
Copy link
Collaborator

yes correct this isn't working there.
not sure if you can do this on web whatsapp...

@mirfilip
Copy link
Author

@c-o-m-m-a-n-d-e-r Right, I'm still forgetting to check if it works in web whatsapp :)

So:

  • [Chrome 49.0.2623.87] uploading via drap&drop doesn't work
  • [Chrome 49.0.2623.87] uploading via upload button does indeed work
  • [Safari 9.1 (11601.5.17.1)] uploading via drap&drop doesn't work
  • [Safari 9.1 (11601.5.17.1)] uploading via upload button does indeed work

So if "Uploading using the upload button is currently not supported, since WKWebView provides no easy mechanism for using tags." still holds true, then I don't think there is any way to add the photo. Maybe we should clear this out in "supported features" table.

@c-o-m-m-a-n-d-e-r
Copy link
Collaborator

thx for your check ... so if its supported generally we can try to implement this in the wrapper ...
i believe we can work with base64 encoded data or something else and paste it into the webviews form ...

@VagishVela VagishVela added the bug label Sep 30, 2016
@VagishVela
Copy link
Owner

VagishVela commented Oct 5, 2016

@mirfilip @c-o-m-m-a-n-d-e-r
#10 and this should be doable since the fix by https://bugs.webkit.org/show_bug.cgi?id=137759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants