Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegEvaluator doesn't work in eval only mode #31

Closed
KerekesDavid opened this issue Sep 10, 2024 · 1 comment
Closed

RegEvaluator doesn't work in eval only mode #31

KerekesDavid opened this issue Sep 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KerekesDavid
Copy link
Collaborator

KerekesDavid commented Sep 10, 2024 •
edited
Loading

model_ckpt_path is not implemented here: https://github.com/yurujaja/geofm-bench/blob/00f1816906b44c1eb80b2b2676543023e7ed45f9/engine/evaluator.py#L202

The evaluators also contain a lot of code that could be unified under the parent class.

@yurujaja this was your code originally (so I don't want to break something in there by accident), but I can fix it if you don't have the time.
@KerekesDavid KerekesDavid added the bug Something isn't working label Sep 15, 2024
@RituYadav92 RituYadav92 mentioned this issue Sep 22, 2024
Merged
@RituYadav92
Copy link
Collaborator

resolved under #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KerekesDavid @RituYadav92