You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The two properties set on the SequenceId for the node object inside the order schema results in the type being compiled to a 'long' within c#.
"minimum": 0,"maximum": 4294967296,
The lack of these two properties on the lastNodeSequenceId for the state object inside the state schema results the type being compiled to a integer within c#.
SequenceId and lastNodeSequenceId should share the same type definition.
The text was updated successfully, but these errors were encountered:
I'm not sure if I can follow correctly.
Since the type "Integer" is defined, but without limits, the code generation in C# automatically creates a long?
And what is the problem with that?
The problem with this is that in c# an integer does not equal a long, therefore if I were to do a compare if a SequenceId is equal to a lastNodeSequenceId or set the value of lastNodeSequenceId to some specific SequenceId, I would need to explicitly cast the one type to the other type every time.
Considering these two properties represent the same value in two separate objects, it would be a nice to have if we would not need to cast between types to interact with these two properties.
If both 0 and 4294967296 should be possible values, then at least 33 bits are required to store these 4294967297 possible values. If the maximum is reduced by one to 4294967295 (0xFFFFFFFF), then the value could be stored in 32 bits.
The two properties set on the SequenceId for the node object inside the order schema results in the type being compiled to a 'long' within c#.
The lack of these two properties on the lastNodeSequenceId for the state object inside the state schema results the type being compiled to a integer within c#.
SequenceId and lastNodeSequenceId should share the same type definition.
The text was updated successfully, but these errors were encountered: