Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malik-Valentine-Capstone-Kanban #21

Open
V-Blaze opened this issue Nov 21, 2022 · 2 comments
Open

Malik-Valentine-Capstone-Kanban #21

V-Blaze opened this issue Nov 21, 2022 · 2 comments

Comments

@V-Blaze
Copy link
Owner

V-Blaze commented Nov 21, 2022

https://github.com/users/V-Blaze/projects/1

We are a Two person team.

@andgarzonmal
Copy link

♻️♻️♻️ STATUS: Changes Required ♻️♻️♻️

Hi Team ✋🏼

Your project is excellent. You are almost done. However, there are some issues you should fix. Please fix them and your project will be approved.


💯 Highlights 💯

  • Nice work setting up your project ✔️

♻️ Request changes ♻️

  • Check the comments .
  • Please ensure all tasks have someone assigned to them.

image
__

Optional suggestions

_Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! 💻 👏

almost


Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@andgarzonmal
Copy link

Hi team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Nice work implementing the required changes ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants