Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/functions-cleanup #30

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Feat/functions-cleanup #30

merged 3 commits into from
Nov 13, 2023

Conversation

cjfullerton
Copy link
Contributor

Cleanup on the functions lesson. Fixes typos, some errors in MATLAB code examples, minor rewording, and MATLAB output for new data.

Copy link

github-actions bot commented Nov 10, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/UoMResearchIT/matlab-novice/compare/md-outputs..md-outputs-PR-30

The following changes were observed in the rendered markdown documents:

 01-intro.md        | 28 +++++++++---------
 02-arrays.md       | 18 ++++++------
 03-loading_data.md | 14 ++++-----
 04-plotting.md     | 20 ++++++-------
 05-scripts.md      |  8 +++---
 06-func.md         | 84 ++++++++++++++++++++++++++----------------------------
 md5sum.txt         | 12 ++++----
 7 files changed, 91 insertions(+), 93 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-11 00:27:13 +0000

@fherreazcue
Copy link
Collaborator

I made a couple of changes, and realised we were not consistent with use of quotes in objectives, questions and keypoints... did not seem correct to use them, so i deleted them all...
Feel free to merge.

@cjfullerton cjfullerton merged commit 9fdac31 into main Nov 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
Auto-generated via {sandpaper}
Source  : 9fdac31
Branch  : main
Author  : Chris Fullerton <[email protected]>
Time    : 2023-11-13 09:44:19 +0000
Message : Merge pull request #30 from UoMResearchIT/feat/functions-cleanup

Feat/functions-cleanup
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
Auto-generated via {sandpaper}
Source  : 9880dcd
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-13 09:46:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9fdac31
Branch  : main
Author  : Chris Fullerton <[email protected]>
Time    : 2023-11-13 09:44:19 +0000
Message : Merge pull request #30 from UoMResearchIT/feat/functions-cleanup

Feat/functions-cleanup
@fherreazcue fherreazcue deleted the feat/functions-cleanup branch November 13, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants