Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webhooks from config to the database #68

Open
TurtIeSocks opened this issue Mar 23, 2023 · 5 comments
Open

Move webhooks from config to the database #68

TurtIeSocks opened this issue Mar 23, 2023 · 5 comments

Comments

@TurtIeSocks
Copy link
Contributor

As title. Move webhook settings from the config to the database and add an API endpoint to hot reload.

@jfberry
Copy link
Collaborator

jfberry commented Mar 23, 2023

Why?

@lenisko
Copy link
Contributor

lenisko commented Mar 23, 2023

Hmm... I think it's a good idea, but worth nothing that restarting Golbat is not troublesome at all.

@jfberry
Copy link
Collaborator

jfberry commented Mar 23, 2023

...and there is no user interface config for golbat, and I'm not sure there would ever need to be
plus how often do you change webhook destinations?

@TurtIeSocks
Copy link
Contributor Author

Ease of setting up, troubleshooting, changing, particularly for dev use.

There isn't a UI, yet. But I see no reason why there shouldn't be some Golbat pages on a certain admin project, particularly if it were to receive it's own server, since it's already making calls to Golbat.

@lenisko
Copy link
Contributor

lenisko commented Mar 23, 2023

I'm always a fan of highly tunnable software. Whole config (aside some critical parts) could be hot-reload through API. Having API, creating UI ang even serving it even via Gin (to make it easy) is easy as pie.

Though! In current state, it would make a small impact, as we don't have enough tunnable switches/options and restart is taking ~3seconds (which is the amount of lost data as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants