Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String conversion for pokemon id & encounters causes excessive cpu #248

Open
jfberry opened this issue Dec 9, 2024 · 3 comments
Open

String conversion for pokemon id & encounters causes excessive cpu #248

jfberry opened this issue Dec 9, 2024 · 3 comments

Comments

@jfberry
Copy link
Collaborator

jfberry commented Dec 9, 2024

@Mygod reports that he has observed this
[if you have pyroscope screenshots demonstrating it, it would be helpful]

I will play to investigate and mitigate if no-one else looks first

@lenisko
Copy link
Contributor

lenisko commented Dec 9, 2024

I don't heave real-time data since I use an outdated Pyroscope instance as a server (new one is PITA to handle).

The problem is... during packages upgrade we bumped pyroscope client. I can collect data later today, but have to downgrade pyroscope package

@lenisko
Copy link
Contributor

lenisko commented Dec 9, 2024

Applied changes on my prd. Data is collected, feel free to take a peak at our shared instance in few hours.

diff --git a/go.mod b/go.mod
index c323ca3..b4ba0f5 100644
--- a/go.mod
+++ b/go.mod
@@ -13,7 +13,7 @@ require (
        github.com/goccy/go-json v0.10.3
        github.com/golang-migrate/migrate/v4 v4.18.1
        github.com/golang/geo v0.0.0-20230421003525-6adc56603217
-       github.com/grafana/pyroscope-go v1.2.0
+       github.com/grafana/pyroscope-go v1.1.2
        github.com/jellydator/ttlcache/v3 v3.3.0
        github.com/jmoiron/sqlx v1.4.0
        github.com/knadh/koanf/maps v0.1.1
diff --git a/go.sum b/go.sum
index b32cf4b..6dc0db5 100644
--- a/go.sum
+++ b/go.sum
@@ -84,6 +84,8 @@ github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
+github.com/grafana/pyroscope-go v1.1.2 h1:7vCfdORYQMCxIzI3NlYAs3FcBP760+gWuYWOyiVyYx8=
+github.com/grafana/pyroscope-go v1.1.2/go.mod h1:HSSmHo2KRn6FasBA4vK7BMiQqyQq8KSuBKvrhkXxYPU=
 github.com/grafana/pyroscope-go v1.2.0 h1:aILLKjTj8CS8f/24OPMGPewQSYlhmdQMBmol1d3KGj8=
 github.com/grafana/pyroscope-go v1.2.0/go.mod h1:2GHr28Nr05bg2pElS+dDsc98f3JTUh2f6Fz1hWXrqwk=
 github.com/grafana/pyroscope-go/godeltaprof v0.1.8 h1:iwOtYXeeVSAeYefJNaxDytgjKtUuKQbJqgAIjlnicKg=

@Mygod
Copy link
Contributor

Mygod commented Dec 9, 2024

More specifically it's causing a lot of ephemeral objects which makes GC work harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants