Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Gohbem Initialization on startup #214

Open
Fabio1988 opened this issue Feb 15, 2024 · 1 comment · May be fixed by #254
Open

Retry Gohbem Initialization on startup #214

Fabio1988 opened this issue Feb 15, 2024 · 1 comment · May be fixed by #254

Comments

@Fabio1988
Copy link
Collaborator

Fabio1988 commented Feb 15, 2024

If the server can't reach the internet on startup (for any reason) gohbem is not initialized and therefore no pvp data can be calculated for raw data arriving later.

Golbat/decoder/main.go

Lines 189 to 192 in 7fbda8b

if err := o.FetchPokemonData(); err != nil {
log.Errorf("ohbem.FetchPokemonData: %s", err)
return
}

@lenisko
Copy link
Contributor

lenisko commented Dec 6, 2024

Leaving last conversation: https://discord.com/channels/1083029607919386654/1088561574664491038/1314606126477742091

So what do we want to do? Either we exit Golbat with non-zero code or process without PvP and retry in a loop.

@Fabio1988 Fabio1988 linked a pull request Dec 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants