Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process GetRaidLobbyCounterOutProto #107

Open
ccev opened this issue Apr 21, 2023 · 0 comments · May be fixed by #124
Open

Process GetRaidLobbyCounterOutProto #107

ccev opened this issue Apr 21, 2023 · 0 comments · May be fixed by #124

Comments

@ccev
Copy link
Collaborator

ccev commented Apr 21, 2023

This is a new message allowing to bulk request raid lobby counts.

Messages

message GetRaidLobbyCounterOutProto {
	enum Result {
		UNSET = 0;
		SUCCESS = 1;
		ERROR_PLAYER_BELOW_MINIMUM_LEVEL = 2;
	}

	Result result = 1;
	repeated RaidLobbyPlayerCountProto raid_lobbies = 2;  // name TBD
}
message RaidLobbyPlayerCountProto {
	string gym_id = 2;
	int32 player_count = 3;
	int64 lobby_join_until_ms = 4;
}

Example response

GetRaidLobbyCounterOutProto {
    result Result.SUCCESS:1
    
    raid_lobbies {  // no active lobby
        gym_id "45a76c2b88ba4529a2f9379de6f88d30.16"
    }
    
    raid_lobbies {
        gym_id "00f9208d76a86794b2178181c304e41d.11"
        player_count 1
        lobby_join_until_ms 1682090628489
    }
}

This will require two new DB fields: lobby_count and lobby_join_end (names TBD) and two new webhook fields. If there's no active lobby, the fields should be null.

Mygod added a commit to Mygod/Golbat that referenced this issue Jun 26, 2023
This sends all raid lobbies directly to webhook and skips persisting to DB.
Fixes UnownHash#107.
Mygod added a commit to Mygod/Golbat that referenced this issue Jun 26, 2023
This sends all raid lobbies directly to webhook and skips persisting to DB.
Adds a new webhook type raid_lobby.
Fixes UnownHash#107.
@Mygod Mygod linked a pull request Jun 26, 2023 that will close this issue
@na-ji na-ji linked a pull request Jun 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant