Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.X] Optifine sky textures reference non-existent files and are missing required properties #9

Open
MarkKoz opened this issue Jan 12, 2022 · 0 comments

Comments

@MarkKoz
Copy link

MarkKoz commented Jan 12, 2022

Describe the Issue
The following source files are referenced but do not exist:

cloud2.png
sky_clouds1.png
sky_starfield.png
cloud2.png
cloud1.png
starfield02.png
sky_sunflare3.png
sky_clouds.png

sky14.properties is missing the following properties, which are documented as required:

startFadeIn
endFadeIn
endFadeOut

To Reproduce
Steps to reproduce the behavior:

  1. Go to assets/minecraft/optifine/sky/world0/
  2. Observe the listed files are missing from the directory.
  3. Open each .properties file
  4. Observe that some reference the listed files or are missing the required properties.

Expected Behavior
Referenced source files should not be missing and all required properties should be present.

Additional Context
I'm attempting to use MCPPPP to convert this resource pack's sky to the FabricSkyboxes format. It works according to spec; it's just that this resource pack is faulty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant