Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Planner with version from universal-router-sdk #414

Open
jfbloom22 opened this issue Oct 1, 2024 · 0 comments
Open

Replace Planner with version from universal-router-sdk #414

jfbloom22 opened this issue Oct 1, 2024 · 0 comments

Comments

@jfbloom22
Copy link

The planner in the universal-router-sdk is more up to date and includes v4 commands. Should we replace /shared/planner.ts with the universal-router-sdk?

https://github.com/Uniswap/sdks/blob/main/sdks/universal-router-sdk/src/utils/routerCommands.ts

Happy to open a PR for this if it is desirable.

The motivation is to make this repo more maintainable and to provide a better example in the integration tests for folks wanting to start using the power of the Uniswap Universal Router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant