diff --git a/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs index 39a37c822242..dbede7418c24 100644 --- a/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs +++ b/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs @@ -60,9 +60,13 @@ use frame_support::{ genesis_builder_helper::{build_state, get_preset}, ord_parameter_types, parameter_types, traits::{ - fungible, fungibles, tokens::imbalance::ResolveAssetTo, AsEnsureOriginWithArg, ConstBool, - ConstU128, ConstU32, ConstU64, ConstU8, EitherOfDiverse, Equals, InstanceFilter, - MapSuccess, TransformOrigin, + fungible, fungibles, + tokens::{ + asset_ops::{common_strategies::Bytes, AssetDefinition, AssetIdOf, InspectMetadata}, + imbalance::ResolveAssetTo, + }, + AsEnsureOriginWithArg, ConstBool, ConstU128, ConstU32, ConstU64, ConstU8, EitherOfDiverse, + Equals, InstanceFilter, MapSuccess, TransformOrigin, }, weights::{ConstantMultiplier, Weight, WeightToFee as _}, BoundedVec, PalletId, @@ -72,6 +76,7 @@ use frame_system::{ EnsureRoot, EnsureSigned, EnsureSignedBy, }; use pallet_asset_conversion_tx_payment::SwapAssetAdapter; +use pallet_nft_fractionalization::{FractionalizedName, FractionalizedSymbol}; use pallet_nfts::PalletFeatures; use parachains_common::{ impls::DealWithFees, @@ -79,7 +84,8 @@ use parachains_common::{ AccountId, AssetIdForTrustBackedAssets, AuraId, Balance, BlockNumber, CollectionId, Hash, Header, ItemId, Nonce, Signature, AVERAGE_ON_INITIALIZE_RATIO, NORMAL_DISPATCH_RATIO, }; -use sp_runtime::{Perbill, RuntimeDebug}; +use scale_info::prelude::{format, string::String}; +use sp_runtime::{DispatchError, Perbill, RuntimeDebug}; use testnet_parachains_constants::rococo::{consensus::*, currency::*, fee::WeightToFee, time::*}; use xcm_config::{ ForeignAssetsConvertedConcreteId, ForeignCreatorsSovereignAccountOf, GovernanceLocation, @@ -868,23 +874,39 @@ impl pallet_uniques::Config for Runtime { parameter_types! { pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction"); - pub NewAssetSymbol: BoundedVec = (*b"FRAC").to_vec().try_into().unwrap(); - pub NewAssetName: BoundedVec = (*b"Frac").to_vec().try_into().unwrap(); +} + +pub struct FractionalizedNfts; +impl AssetDefinition for FractionalizedNfts { + type Id = AssetIdOf>; +} +impl InspectMetadata> for FractionalizedNfts { + fn inspect_metadata( + (collection_id, item_id): &Self::Id, + _frac_name: Bytes, + ) -> Result, DispatchError> { + Ok(format!("Frac {collection_id}-{item_id}").into_bytes()) + } +} +impl InspectMetadata> for FractionalizedNfts { + fn inspect_metadata( + _instance_id: &Self::Id, + _frac_name: Bytes, + ) -> Result, DispatchError> { + Ok(String::from("FRAC").into_bytes()) + } } impl pallet_nft_fractionalization::Config for Runtime { type RuntimeEvent = RuntimeEvent; type Deposit = AssetDeposit; type Currency = Balances; - type NewAssetSymbol = NewAssetSymbol; - type NewAssetName = NewAssetName; - type StringLimit = AssetsStringLimit; - type NftCollectionId = ::CollectionId; - type NftId = ::ItemId; type AssetBalance = ::Balance; type AssetId = >::AssetId; type Assets = Assets; - type Nfts = Nfts; + type NftId = AssetIdOf>; + type Nfts = pallet_nfts::asset_ops::Item; + type FractionalizedNfts = FractionalizedNfts; type PalletId = NftFractionalizationPalletId; type WeightInfo = pallet_nft_fractionalization::weights::SubstrateWeight; type RuntimeHoldReason = RuntimeHoldReason; diff --git a/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs b/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs index 605e63cae43a..a4e6cd616257 100644 --- a/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs +++ b/cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs @@ -44,7 +44,12 @@ use frame_support::{ ord_parameter_types, parameter_types, traits::{ fungible, fungibles, - tokens::{imbalance::ResolveAssetTo, nonfungibles_v2::Inspect, ConversionToAssetBalance}, + tokens::{ + asset_ops::{common_strategies::Bytes, AssetDefinition, AssetIdOf, InspectMetadata}, + imbalance::ResolveAssetTo, + nonfungibles_v2::Inspect, + ConversionToAssetBalance, + }, AsEnsureOriginWithArg, ConstBool, ConstU128, ConstU32, ConstU64, ConstU8, Equals, InstanceFilter, MapSuccess, TransformOrigin, }, @@ -56,6 +61,7 @@ use frame_system::{ EnsureRoot, EnsureSigned, EnsureSignedBy, }; use pallet_asset_conversion_tx_payment::SwapAssetAdapter; +use pallet_nft_fractionalization::{FractionalizedName, FractionalizedSymbol}; use pallet_nfts::{DestroyWitness, PalletFeatures}; use pallet_xcm::EnsureXcm; use parachains_common::{ @@ -63,6 +69,7 @@ use parachains_common::{ BlockNumber, CollectionId, Hash, Header, ItemId, Nonce, Signature, AVERAGE_ON_INITIALIZE_RATIO, NORMAL_DISPATCH_RATIO, }; +use scale_info::prelude::{format, string::String}; use sp_api::impl_runtime_apis; use sp_core::{crypto::KeyTypeId, OpaqueMetadata}; use sp_runtime::{ @@ -72,7 +79,7 @@ use sp_runtime::{ Saturating, Verify, }, transaction_validity::{TransactionSource, TransactionValidity}, - ApplyExtrinsicResult, Perbill, Permill, RuntimeDebug, + ApplyExtrinsicResult, DispatchError, Perbill, Permill, RuntimeDebug, }; #[cfg(feature = "std")] use sp_version::NativeVersion; @@ -860,23 +867,39 @@ impl pallet_uniques::Config for Runtime { parameter_types! { pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction"); - pub NewAssetSymbol: BoundedVec = (*b"FRAC").to_vec().try_into().unwrap(); - pub NewAssetName: BoundedVec = (*b"Frac").to_vec().try_into().unwrap(); +} + +pub struct FractionalizedNfts; +impl AssetDefinition for FractionalizedNfts { + type Id = AssetIdOf>; +} +impl InspectMetadata> for FractionalizedNfts { + fn inspect_metadata( + (collection_id, item_id): &Self::Id, + _frac_name: Bytes, + ) -> Result, DispatchError> { + Ok(format!("Frac {collection_id}-{item_id}").into_bytes()) + } +} +impl InspectMetadata> for FractionalizedNfts { + fn inspect_metadata( + _instance_id: &Self::Id, + _frac_name: Bytes, + ) -> Result, DispatchError> { + Ok(String::from("FRAC").into_bytes()) + } } impl pallet_nft_fractionalization::Config for Runtime { type RuntimeEvent = RuntimeEvent; type Deposit = AssetDeposit; type Currency = Balances; - type NewAssetSymbol = NewAssetSymbol; - type NewAssetName = NewAssetName; - type StringLimit = AssetsStringLimit; - type NftCollectionId = ::CollectionId; - type NftId = ::ItemId; type AssetBalance = ::Balance; type AssetId = >::AssetId; type Assets = Assets; - type Nfts = Nfts; + type NftId = AssetIdOf>; + type Nfts = pallet_nfts::asset_ops::Item; + type FractionalizedNfts = FractionalizedNfts; type PalletId = NftFractionalizationPalletId; type WeightInfo = pallet_nft_fractionalization::weights::SubstrateWeight; type RuntimeHoldReason = RuntimeHoldReason; diff --git a/substrate/frame/nft-fractionalization/src/lib.rs b/substrate/frame/nft-fractionalization/src/lib.rs index 5fa990ecebe6..3ddbef471499 100644 --- a/substrate/frame/nft-fractionalization/src/lib.rs +++ b/substrate/frame/nft-fractionalization/src/lib.rs @@ -56,7 +56,6 @@ pub use weights::WeightInfo; #[frame_support::pallet] pub mod pallet { use super::*; - use core::fmt::Display; use frame_support::{ dispatch::DispatchResult, ensure, @@ -72,17 +71,19 @@ pub mod pallet { Create, Destroy, Inspect, Mutate, }, tokens::{ - nonfungibles_v2::{Inspect as NonFungiblesInspect, Transfer}, + asset_ops::{ + common_strategies::{Bytes, CanTransfer, JustDo, Ownership}, + AssetDefinition, InspectMetadata, Transfer, UpdateMetadata, + }, AssetId, Balance as AssetBalance, Fortitude::Polite, Precision::{BestEffort, Exact}, Preservation::{Expendable, Preserve}, }, }, - BoundedVec, PalletId, + PalletId, }; use frame_system::pallet_prelude::*; - use scale_info::prelude::{format, string::String}; use sp_runtime::traits::{One, Zero}; #[pallet::pallet] @@ -106,11 +107,8 @@ pub mod pallet { #[pallet::constant] type Deposit: Get>; - /// Identifier for the collection of NFT. - type NftCollectionId: Member + Parameter + MaxEncodedLen + Copy + Display; - - /// The type used to identify an NFT within a collection. - type NftId: Member + Parameter + MaxEncodedLen + Copy + Display; + /// The type used to identify an NFT. + type NftId: Member + Parameter + MaxEncodedLen; /// The type used to describe the amount of fractions converted into assets. type AssetBalance: AssetBalance; @@ -127,28 +125,19 @@ pub mod pallet { + MetadataDeposit>; /// Registry for minted NFTs. - type Nfts: NonFungiblesInspect< - Self::AccountId, - ItemId = Self::NftId, - CollectionId = Self::NftCollectionId, - > + Transfer; + type Nfts: AssetDefinition + + InspectMetadata> + + UpdateMetadata + + Transfer>; + + type FractionalizedNfts: AssetDefinition + + InspectMetadata> + + InspectMetadata>; /// The pallet's id, used for deriving its sovereign account ID. #[pallet::constant] type PalletId: Get; - /// The newly created asset's symbol. - #[pallet::constant] - type NewAssetSymbol: Get>; - - /// The newly created asset's name. - #[pallet::constant] - type NewAssetName: Get>; - - /// The maximum length of a name or symbol stored on-chain. - #[pallet::constant] - type StringLimit: Get; - /// A set of helper functions for benchmarking. #[cfg(feature = "runtime-benchmarks")] type BenchmarkHelper: BenchmarkHelper; @@ -163,7 +152,7 @@ pub mod pallet { pub type NftToAsset = StorageMap< _, Blake2_128Concat, - (T::NftCollectionId, T::NftId), + T::NftId, Details, AssetBalanceOf, DepositOf, T::AccountId>, OptionQuery, >; @@ -173,19 +162,13 @@ pub mod pallet { pub enum Event { /// An NFT was successfully fractionalized. NftFractionalized { - nft_collection: T::NftCollectionId, nft: T::NftId, fractions: AssetBalanceOf, asset: AssetIdOf, beneficiary: T::AccountId, }, /// An NFT was successfully returned back. - NftUnified { - nft_collection: T::NftCollectionId, - nft: T::NftId, - asset: AssetIdOf, - beneficiary: T::AccountId, - }, + NftUnified { nft: T::NftId, asset: AssetIdOf, beneficiary: T::AccountId }, } #[pallet::error] @@ -217,9 +200,7 @@ pub mod pallet { /// /// `Deposit` funds of sender are reserved. /// - /// - `nft_collection_id`: The ID used to identify the collection of the NFT. - /// Is used within the context of `pallet_nfts`. - /// - `nft_id`: The ID used to identify the NFT within the given collection. + /// - `nft_id`: The ID used to identify the NFT. /// Is used within the context of `pallet_nfts`. /// - `asset_id`: The ID of the new asset. It must not exist. /// Is used within the context of `pallet_assets`. @@ -231,7 +212,6 @@ pub mod pallet { #[pallet::weight(T::WeightInfo::fractionalize())] pub fn fractionalize( origin: OriginFor, - nft_collection_id: T::NftCollectionId, nft_id: T::NftId, asset_id: AssetIdOf, beneficiary: AccountIdLookupOf, @@ -240,31 +220,23 @@ pub mod pallet { let who = ensure_signed(origin)?; let beneficiary = T::Lookup::lookup(beneficiary)?; - let nft_owner = - T::Nfts::owner(&nft_collection_id, &nft_id).ok_or(Error::::NftNotFound)?; + let nft_owner = T::Nfts::inspect_metadata(&nft_id, Ownership::default())?; ensure!(nft_owner == who, Error::::NoPermission); let pallet_account = Self::get_pallet_account(); let deposit = T::Deposit::get(); T::Currency::hold(&HoldReason::Fractionalized.into(), &nft_owner, deposit)?; - Self::do_lock_nft(nft_collection_id, nft_id)?; + Self::do_lock_nft(&nft_id)?; Self::do_create_asset(asset_id.clone(), pallet_account.clone())?; Self::do_mint_asset(asset_id.clone(), &beneficiary, fractions)?; - Self::do_set_metadata( - asset_id.clone(), - &who, - &pallet_account, - &nft_collection_id, - &nft_id, - )?; + Self::do_set_metadata(asset_id.clone(), &who, &pallet_account, &nft_id)?; NftToAsset::::insert( - (nft_collection_id, nft_id), + &nft_id, Details { asset: asset_id.clone(), fractions, asset_creator: nft_owner, deposit }, ); Self::deposit_event(Event::NftFractionalized { - nft_collection: nft_collection_id, nft: nft_id, fractions, asset: asset_id, @@ -280,8 +252,6 @@ pub mod pallet { /// /// `Deposit` funds will be returned to `asset_creator`. /// - /// - `nft_collection_id`: The ID used to identify the collection of the NFT. - /// Is used within the context of `pallet_nfts`. /// - `nft_id`: The ID used to identify the NFT within the given collection. /// Is used within the context of `pallet_nfts`. /// - `asset_id`: The ID of the asset being returned and destroyed. Must match @@ -294,7 +264,6 @@ pub mod pallet { #[pallet::weight(T::WeightInfo::unify())] pub fn unify( origin: OriginFor, - nft_collection_id: T::NftCollectionId, nft_id: T::NftId, asset_id: AssetIdOf, beneficiary: AccountIdLookupOf, @@ -302,14 +271,14 @@ pub mod pallet { let who = ensure_signed(origin)?; let beneficiary = T::Lookup::lookup(beneficiary)?; - NftToAsset::::try_mutate_exists((nft_collection_id, nft_id), |maybe_details| { + NftToAsset::::try_mutate_exists(nft_id.clone(), |maybe_details| { let details = maybe_details.take().ok_or(Error::::NftNotFractionalized)?; ensure!(details.asset == asset_id, Error::::IncorrectAssetId); let deposit = details.deposit; let asset_creator = details.asset_creator; Self::do_burn_asset(asset_id.clone(), &who, details.fractions)?; - Self::do_unlock_nft(nft_collection_id, nft_id, &beneficiary)?; + Self::do_unlock_nft(&nft_id, &beneficiary)?; T::Currency::release( &HoldReason::Fractionalized.into(), &asset_creator, @@ -318,7 +287,6 @@ pub mod pallet { )?; Self::deposit_event(Event::NftUnified { - nft_collection: nft_collection_id, nft: nft_id, asset: asset_id, beneficiary, @@ -339,18 +307,14 @@ pub mod pallet { } /// Prevent further transferring of NFT. - fn do_lock_nft(nft_collection_id: T::NftCollectionId, nft_id: T::NftId) -> DispatchResult { - T::Nfts::disable_transfer(&nft_collection_id, &nft_id) + fn do_lock_nft(nft_id: &T::NftId) -> DispatchResult { + T::Nfts::update_metadata(nft_id, CanTransfer::default(), false) } /// Remove the transfer lock and transfer the NFT to the account returning the tokens. - fn do_unlock_nft( - nft_collection_id: T::NftCollectionId, - nft_id: T::NftId, - account: &T::AccountId, - ) -> DispatchResult { - T::Nfts::enable_transfer(&nft_collection_id, &nft_id)?; - T::Nfts::transfer(&nft_collection_id, &nft_id, account) + fn do_unlock_nft(nft_id: &T::NftId, account: &T::AccountId) -> DispatchResult { + T::Nfts::update_metadata(nft_id, CanTransfer::default(), true)?; + T::Nfts::transfer(nft_id, JustDo(account.clone())) } /// Create the new asset. @@ -383,25 +347,29 @@ pub mod pallet { asset_id: AssetIdOf, depositor: &T::AccountId, pallet_account: &T::AccountId, - nft_collection_id: &T::NftCollectionId, nft_id: &T::NftId, ) -> DispatchResult { - let name = format!( - "{} {nft_collection_id}-{nft_id}", - String::from_utf8_lossy(&T::NewAssetName::get()) - ); - let symbol: &[u8] = &T::NewAssetSymbol::get(); + let fractionalized_name: &[u8] = + &T::FractionalizedNfts::inspect_metadata(&nft_id, Bytes(FractionalizedName))?; + let symbol: &[u8] = + &T::FractionalizedNfts::inspect_metadata(&nft_id, Bytes(FractionalizedSymbol))?; let existential_deposit = T::Currency::minimum_balance(); let pallet_account_balance = T::Currency::balance(&pallet_account); if pallet_account_balance < existential_deposit { T::Currency::transfer(&depositor, &pallet_account, existential_deposit, Preserve)?; } - let metadata_deposit = T::Assets::calc_metadata_deposit(name.as_bytes(), symbol); + let metadata_deposit = T::Assets::calc_metadata_deposit(fractionalized_name, symbol); if !metadata_deposit.is_zero() { T::Currency::transfer(&depositor, &pallet_account, metadata_deposit, Preserve)?; } - T::Assets::set(asset_id, &pallet_account, name.into(), symbol.into(), 0) + T::Assets::set(asset_id, &pallet_account, fractionalized_name.into(), symbol.into(), 0) } } } + +/// Bytes to be used as the name of the fractionalized asset. +pub struct FractionalizedName; + +/// Bytes to be used as the symbol of the fractionalized asset. +pub struct FractionalizedSymbol;