Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External URIs #34

Open
richardmarcus opened this issue Nov 11, 2019 · 4 comments
Open

External URIs #34

richardmarcus opened this issue Nov 11, 2019 · 4 comments

Comments

@richardmarcus
Copy link
Collaborator

richardmarcus commented Nov 11, 2019

@kohlhase
Copy link
Member

I think this is something related to https://medium.com/@dtkatz/3-ways-to-fix-the-cors-error-and-how-access-control-allow-origin-works-d97d55946d9
We could fix it at the level of MathHub but that would not help TGView itself.

@richardmarcus
Copy link
Collaborator Author

the second solution with https://cors-anywhere.herokuapp.com/ as proxy seems to work fine, but not sure if we want to rely on this in the future

@kohlhase
Copy link
Member

Well maybe this is something for standalone TGView. In MathHub we already have a proxy we could (better) use (maybe extend for this). This is closer to solution 3.
@richardmarcus why don't you implement solution2 for tgview3D standalone and @tkw1536 can think about the MathHub integration.

@richardmarcus
Copy link
Collaborator Author

Standalone TGView is not affected because CORS only affects browser-server communication.
Until we have something better, I integrated the mentioned proxy.
https://tgview3d.mathhub.info/?kwarc.info/teaching/IWGS/graph.json now automatically loads the IWGS graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants