Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic chat support #1

Closed
3 tasks done
UncleVasya opened this issue Dec 10, 2016 · 2 comments
Closed
3 tasks done

Basic chat support #1

UncleVasya opened this issue Dec 10, 2016 · 2 comments
Labels
enhancement

Comments

@UncleVasya
Copy link
Owner

UncleVasya commented Dec 10, 2016 •
edited
Loading

Bare minimum that I need to procees with UncleVasya/Dota2-EU-Ladder#9

  • jon lobby chat;
  • read messages;
  • send messages;

When have time, finish other features and make PR:
This was referenced Dec 10, 2016
Closed
Closed
@UncleVasya
Copy link
Owner Author

Need small refactoring:

  • self.send_lobby_message() does't need lobby_id argument, we can get it from self.lobby.lobby_id inside the method (because we can be only in 1 lobby at a time anyway);
  • we probably don't need an chat_joined event, simple job should be enough;

@UncleVasya
Copy link
Owner Author

No longer needed, already implemented in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UncleVasya