Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop searching for streams once one is found #264

Closed
mat1jaczyyy opened this issue May 1, 2020 · 3 comments · Fixed by #267
Closed

Don't stop searching for streams once one is found #264

mat1jaczyyy opened this issue May 1, 2020 · 3 comments · Fixed by #267
Assignees
Labels

Comments

@mat1jaczyyy
Copy link

For my DVR, the first hit (/StreamingSetting?version=1.0...) was a 200 OK with a stream, although the stream itself was dummy and not actually displaying the camera feed, only the current time and date. It took me a while to figure out if I remove this hit from the routes file, I hit (avn=2) which gives me exactly the camera feed I want.

I feel it would be nice if cameradar kept searching through all streams and display all hits at the end of the search; or pause when a hit is found, display it to the user and ask the user if they want to keep searching.

@Ullaakut
Copy link
Owner

Ullaakut commented May 3, 2020

Hi @mat1jaczyyy ! Thanks for sharing your idea :)

This issue is similar to #263, I'll try to solve both issues together in the next versions by making cameradar continue to try paths even when it finds them.

I am worried about one thing however, which is that some cameras will answer 200 OK to / because they serve the stream directly on the root path, but also will answer 200 OK to everything else, so I should probably implement some kind of protection to avoid having 150 routes displayed for a camera that has this behavior.

@Ullaakut Ullaakut self-assigned this May 3, 2020
@mat1jaczyyy
Copy link
Author

In that case - you can probably attempt to request a stream which would obviously 404, like a random string of letters for the URL. If it answers 200 OK, a warning would be nice. Thanks!

@Ullaakut
Copy link
Owner

Ullaakut commented May 4, 2020

Screenshot 2020-05-04 at 12 31 34 AM

Done :) I will be releasing this version in the next few days, I just need to do some testing since I introduced some breaking changes, and I'll open a PR that fixes this issue 👍 Thanks again for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants