Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Create a Card Component #49

Open
1 task done
divyamrastogi opened this issue May 9, 2018 · 3 comments
Open
1 task done

[Frontend] Create a Card Component #49

divyamrastogi opened this issue May 9, 2018 · 3 comments
Labels
Critical This is a critical issue taken issue has been assigned and assignee is on it

Comments

@divyamrastogi
Copy link
Collaborator

divyamrastogi commented May 9, 2018

I'm submitting a ...

  • feature request

Current behavior:
We need a Card component so as to reuse on the project description page based on the design

Expected behavior:
Anyone should be able to use the card component in this way:

<Card onClick={someHandler} detail={true} detailText="Click Here">
  <div className="title">This is the title</div>
  <div className="description">This is the description</div>
</Card>

onClick can be an optional property.
detail can be false by default and is optional.
detailText is a configurable and optional string parameter in case there's a link below the description with a default value of 'Read More'.

There are basically three main variations of this component.

@anurag-majumdar
Copy link
Contributor

I can work on this feature.

@divyamrastogi divyamrastogi added Critical This is a critical issue taken issue has been assigned and assignee is on it labels May 9, 2018
@divyamrastogi divyamrastogi changed the title Create a Card Component [Frontend] Create a Card Component May 9, 2018
@anurag-majumdar
Copy link
Contributor

anurag-majumdar commented May 11, 2018

@divyamrastogi @blenderskool

This is how it looks now, just like it was mentioned.

image

I have a few doubts:

  1. Will this card be only used for detailed texts and descriptions and the click for read more if extra data is there?
  2. I guess we need to set a default height for this type of card with descriptions instead of height of card as 100%.
  3. The Read More button will make sure we go to the next page for detailed read that can be optional and passed as a click handler.

There may be some minor css changes required later on if it comes to mind, but followed the design and style. Let me know what do you guys think?

@anurag-majumdar
Copy link
Contributor

Made changes to shadow of the card component. Made it as shown in the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical This is a critical issue taken issue has been assigned and assignee is on it
Projects
None yet
Development

No branches or pull requests

2 participants