Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create required UI components for the front-end #46

Open
1 of 2 tasks
blenderskool opened this issue May 8, 2018 · 8 comments
Open
1 of 2 tasks

Create required UI components for the front-end #46

blenderskool opened this issue May 8, 2018 · 8 comments
Assignees
Labels
taken issue has been assigned and assignee is on it

Comments

@blenderskool
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request

Current behavior:

As of now, most of the issues are open to other developers on per-layout basis. Since the app uses fundamental components throughout the app, every page may end up having different styles for every component which makes it really cumbersome to manage.

Expected behavior:

We can first create the fundamental components required in the app. This would allow other developers to join in and quickly create the layouts based on the desings. I am ready to start working on this 🙂

@anurag-majumdar
Copy link
Contributor

@blenderskool This is quite an important task indeed. Will you be carrying this feature out by yourself or you would like one more person to join in with you? If you need help I can assist you with these fundamental components. 😃

@blenderskool
Copy link
Contributor Author

@anurag-majumdar Yes, even you can contribute. Based on some component guidelines that I have added to the albums, we can divide the components between ourselves.

@realslimshanky
Copy link
Collaborator

@blenderskool if this is the case, one has to create UI components. And then those components can be used by other contributors for layout development.
Inversely, since we have fixed views, those views can be designed individually to each other. Since we have very few time left till the end of the course we should have a working model. In future if we get time we can unify similar components.
What do you guys think?
@divyamrastogi @PrabhanshuAttri @palnabarun @shubhshrma @ParthS007 @ritikrishu

@divyamrastogi
Copy link
Collaborator

I actually agree with @blenderskool because it's not that hard to identify reusable components. Believe me, it saves a lot of time if you think ahead and plan these things a little.

In fact, even the layout can be a component since we've got a similar structure of the header section and the rest of the page. Let me identify these components and I'll create issues for them. Then, we can reuse those components to pick up issues created by @realslimshanky. What say?

@realslimshanky
Copy link
Collaborator

@divyamrastogi great. Thanks for taking such a huge task. Would help a lot in future processes.

@blenderskool
Copy link
Contributor Author

@realslimshanky @divyamrastogi I have already added some in-depth component guidelines here https://photos.app.goo.gl/5nm1W01LSmGwOfGh2
Additional components can be created based on these principles

@realslimshanky realslimshanky added the taken issue has been assigned and assignee is on it label May 8, 2018
@anurag-majumdar
Copy link
Contributor

Guys, before we dive in to the components part, we need to also add that we are changing the version from latest material-ui to the stable one 0.20. I am working on this part and will issue a PR soon.

The UI layouts are going to use 0.20 version of material-ui.

@anurag-majumdar
Copy link
Contributor

Please ignore the last comment regarding 0.20. We are continuing with material-ui@next.
Are the reusable components in place? Then we can start building the pages asap.

@divyamrastogi @blenderskool @realslimshanky @PrabhanshuAttri @palnabarun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
taken issue has been assigned and assignee is on it
Projects
None yet
Development

No branches or pull requests

4 participants