-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need of Continuous Integration services #4
Comments
I have the idea about setting up Travis but not much idea about tests in the Javascript/React world. @divyamrastogi @ritikrishu Please provide your inputs. |
@palnabarun: I can handle the unit tests. |
Great. :) Please also link some articles here which lets new contributors know about unit testing in ReactJS. |
@divyamrastogi we have few tests written by CRA as well. You might wanna include them as well. https://github.com/UdacityMobileWebScholarship/showcase-app#running-tests |
@realslimshanky : That's the plan, they've got a few examples already. I'll include some good tutorials for writing unit tests as well, so that everyone who's going to be writing components will be able to write unit tests for them. |
So where can we find the individual components that we need to code? |
@highskillzz soon you'll find issues for modules and components. Once we finalize the designs we'll be flooding those out to you, so you might want to keep an eye🔭 on #5 |
We can use SonarQube , https://www.sonarqube.org/ for the code smells , vulnerability in the code, unused imports , code coverage. |
I can work upon linking that to project if it is not added yet |
@nikitasharma2692 Let us first get a basic Travis setup working. Then we can add other integrations. |
@divyamrastogi are we using Jest and Enzyme for testing our components? |
We'll be using Jest, since Facebook is the one who created it., forit Testing. Travis CI will be our CI tool. |
@divyamrastogi I can help you in setting up of Travis CI and Codecov(for code coverage). |
@divyamrastogi We can also add codacy for checking the quality of PR. |
All right, I'll definitely look at all these options and we'll cover all the bases. Unit Testing, E2E, Code Coverage are the ones we'll start with. Let's do this on Sunday evening. By then we will have a few components to start coding, hopefully. |
It'd be a good idea to ask the people who add new features to provide unit tests for the same. |
@divyamrastogi any update on this issue? |
I'll make a few components of our design and add unit tests for them by tomorrow. That should serve as a guideline. |
This is really needed to check the code quality pushed by the contributors, be it code or documentation. Travis CI can be used for the purpose.
The text was updated successfully, but these errors were encountered: