Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Material-UI dependency version #38

Open
1 of 2 tasks
realslimshanky opened this issue May 7, 2018 · 7 comments
Open
1 of 2 tasks

Fixing Material-UI dependency version #38

realslimshanky opened this issue May 7, 2018 · 7 comments
Labels
taken issue has been assigned and assignee is on it

Comments

@realslimshanky
Copy link
Collaborator

I'm submitting a ...

  • bug report
  • feature request

Current behavior:
Currently, Material-UI is set to next in the project dependency or package.json which is the pre-release and not stable.

Expected behavior:
We should be using the stable and version. Which means the version should be stated as the latest stable which currently is 0.20.0 as stated in NPM. Let's use pin this version and then move forward.

Steps to reproduce:
Just look at Package.json

@realslimshanky realslimshanky added bug Something isn't working good first issue Good for newcomers Urgent This requirement is urgent Critical This is a critical issue labels May 7, 2018
@ritikrishu ritikrishu added the open for claim this issue is open for anyone who wants to contribute label May 7, 2018
@anurag-majumdar
Copy link
Contributor

So we need to set the version of material-ui back to 0.20 and install the dependencies? I can take up this issue.

@realslimshanky
Copy link
Collaborator Author

@anurag-majumdar 0.20.0 is the correct version. Go ahead raise a PR. I'm assigning this issue to you.

@realslimshanky realslimshanky added taken issue has been assigned and assignee is on it and removed Critical This is a critical issue Urgent This requirement is urgent bug Something isn't working good first issue Good for newcomers open for claim this issue is open for anyone who wants to contribute labels May 8, 2018
@anurag-majumdar
Copy link
Contributor

Will let you know asap I fix the version and the dependencies. Thanks @realslimshanky.

@anurag-majumdar
Copy link
Contributor

anurag-majumdar commented May 9, 2018

There is one thing I saw, the existing styles and all would seem to break and need to refactor those areas for changing the version from 'next' to 0.20. I will also refactor those areas as much as possible.

I have initiated a PR, but I will be working on streamlining the changes from 'next' to '0.20' in order to get the app working. This is a dependency on version change. I will be adding further commits to the PR #51

@realslimshanky @divyamrastogi @palnabarun @blenderskool

@blenderskool
Copy link
Contributor

@realslimshanky @anurag-majumdar It is good to be on stable version, but looking at 0.20.0 documentation, I see many differences in styling compared to next version which is more close to real guidelines.

Also overriding components with this version is easier and allows more options 🙂

@anurag-majumdar
Copy link
Contributor

@blenderskool is actually right regarding this area, even if 0.20 is a stable version, it does not have some of the new features as next has. Also, next and 0.20 are not completely backwards compatible and a lot of refactoring needs to be done here.

@ritikrishu
Copy link
Collaborator

I think material UI recommends to use next version for new projects. So this is fine. But yeah, instead of @next we should be using a fixed version number whichever is latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
taken issue has been assigned and assignee is on it
Projects
None yet
Development

No branches or pull requests

4 participants