-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Material-UI dependency version #38
Comments
So we need to set the version of material-ui back to 0.20 and install the dependencies? I can take up this issue. |
@anurag-majumdar |
Will let you know asap I fix the version and the dependencies. Thanks @realslimshanky. |
There is one thing I saw, the existing styles and all would seem to break and need to refactor those areas for changing the version from 'next' to 0.20. I will also refactor those areas as much as possible. I have initiated a PR, but I will be working on streamlining the changes from 'next' to '0.20' in order to get the app working. This is a dependency on version change. I will be adding further commits to the PR #51 |
@realslimshanky @anurag-majumdar It is good to be on stable version, but looking at 0.20.0 documentation, I see many differences in styling compared to next version which is more close to real guidelines. Also overriding components with this version is easier and allows more options 🙂 |
@blenderskool is actually right regarding this area, even if 0.20 is a stable version, it does not have some of the new features as next has. Also, next and 0.20 are not completely backwards compatible and a lot of refactoring needs to be done here. |
I think material UI recommends to use next version for new projects. So this is fine. But yeah, instead of |
I'm submitting a ...
Current behavior:
Currently, Material-UI is set to
next
in the project dependency or package.json which is the pre-release and not stable.Expected behavior:
We should be using the stable and version. Which means the version should be stated as the latest stable which currently is
0.20.0
as stated in NPM. Let's use pin this version and then move forward.Steps to reproduce:
Just look at Package.json
The text was updated successfully, but these errors were encountered: