Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on UI using Bootstrap. #17

Open
4 tasks
LoneWolf36 opened this issue Apr 28, 2018 · 13 comments
Open
4 tasks

Working on UI using Bootstrap. #17

LoneWolf36 opened this issue Apr 28, 2018 · 13 comments

Comments

@LoneWolf36
Copy link
Contributor

LoneWolf36 commented Apr 28, 2018

Thank you for contributing by opening an issue! Please review this guide before submitting your issue.

I'm opening this issue because: I want to setup the manifest file and work on UI using Bootstrap.

  • Other (see below for feature requests):
  • node -v prints: v9.11.1
  • npm -v prints: 6.0.0
  • Windows, OS X/macOS, or Linux?: Linux
  • Browser: Chrome

What's the feature? Adding a proper manifest file and setting up the icons and working on the UI using Bootstrap

What problem is the feature intended to solve?

Is this feature similar to an existing feature in another app somewhere?

Is this a feature you're prepared to implement? Yes!

@whimsicaldreamer
Copy link
Collaborator

whimsicaldreamer commented Apr 28, 2018

Could you please check home-screen branch to see if manifest, icons are properly setup? You can contribute there.
Since you want to work on UI, try without using Bootstrap as we don't want to be completely dependent on it.

@Nagendra1421
Copy link
Collaborator

Manifest is already implemented on client side, you can find it in public folder

@LoneWolf36
Copy link
Contributor Author

LoneWolf36 commented Apr 28, 2018

It's implemented, but it's not doing what it's supposed to.
There are no icons etc. Allow me to set that up : )

@skyshader
Copy link
Collaborator

@ManajitPal can you generate the favicons and add to this repository?
You can use this: https://realfavicongenerator.net/

@LoneWolf36
Copy link
Contributor Author

@whimsicaldreamer Alright! I'll have a look at it : )

@LoneWolf36
Copy link
Contributor Author

@skyshader I was working on it : )
Allow me to continue on it?

@whimsicaldreamer
Copy link
Collaborator

whimsicaldreamer commented Apr 28, 2018

@skyshader I have added favicons to the home-screen branch already. Waiting to push it after some additions.

@ManajitPal
Copy link
Contributor

I would suggest working on UI without using bootstrap. Use flexbox/CSS grids instead. Check the ayan-home-screen branch for proper structuring of all the UI stuff. Also, use the variables defined in dark.css to add colors to the project instead of defining colors in your CSS. Cheers! 👍

@ManajitPal ManajitPal changed the title Adding manifest, icons and working on UI using Bootstrap. Working on UI using Bootstrap. Apr 30, 2018
@vipinkhushu
Copy link

Hi @LoneWolf36 ,
Is there some bootstrap task, i am interested.

@LoneWolf36
Copy link
Contributor Author

Yes there is, there's a ayan-home-screen branch in which there's the UI development going, you could contribute there.

@whimsicaldreamer
Copy link
Collaborator

@vipinkhushu @LoneWolf36 in ayan-home-screen branch we are working without bootstrap.

@vipinkhushu
Copy link

@LoneWolf36 @whimsicaldreamer Working without bootstrap will be fine for me..

@Ankk98
Copy link

Ankk98 commented May 12, 2018

Is this issue resolved or any work is remaining?
I am interested in contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants