Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Cache Duration: 1 Month #15

Open
maerki opened this issue Feb 22, 2022 · 2 comments
Open

Default Cache Duration: 1 Month #15

maerki opened this issue Feb 22, 2022 · 2 comments
Assignees

Comments

@maerki
Copy link
Contributor

maerki commented Feb 22, 2022

guard let defaultCachingLimit = calendar.date(byAdding: .month, value: 1, to: responseDate) else {

For most projects, there should always be cache headers. Nevertheless, 1 month default can be confusing and makes early stage development unnecessarily hard.

Suggestion: 1 Hour

@maerki
Copy link
Contributor Author

maerki commented Feb 22, 2022

Was man in dem Kontext auch gerade noch machen könnte: Eine Info-Message loggen, wenn der Server kein Caching definiert.

@ubfelix
Copy link
Contributor

ubfelix commented Feb 28, 2022

@joseph-elmallah what do you think? Should we change the default to 1 hour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants