Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Face Centroid Calculations #1116

Open
erogluorhan opened this issue Dec 21, 2024 · 0 comments · May be fixed by #1117
Open

Optimize Face Centroid Calculations #1116

erogluorhan opened this issue Dec 21, 2024 · 0 comments · May be fixed by #1117
Assignees
Labels
improvement Improvements on existing features or infrastructure scalability Related to scalability & performance efforts

Comments

@erogluorhan
Copy link
Member

erogluorhan commented Dec 21, 2024

If Grid.face_lon does not exist, _populate_face_centroids(), actually _construct_face_centroids() in it, takes extremely long for large datasets. For instance, the benchmark/profiling below is for a ~4GB SCREAM dataset, around 5 mins:

@rajeeja FYI: I'm already working on this and have gotten optimized results, which will be good for "cartesian" parts of the face center calculations, but you may want to look into the Welzl parts as well, i.e. _populate_face_centerpoints().

Image
@erogluorhan erogluorhan added improvement Improvements on existing features or infrastructure scalability Related to scalability & performance efforts labels Dec 21, 2024
@erogluorhan erogluorhan self-assigned this Dec 21, 2024
@github-project-automation github-project-automation bot moved this to 📚 Backlog in UXarray Development Dec 21, 2024
@erogluorhan erogluorhan linked a pull request Dec 21, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on existing features or infrastructure scalability Related to scalability & performance efforts
Projects
Status: 📚 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant