Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for .xls(x) DS input #13

Open
sarahcn opened this issue Jun 1, 2018 · 3 comments
Open

allow for .xls(x) DS input #13

sarahcn opened this issue Jun 1, 2018 · 3 comments

Comments

@sarahcn
Copy link
Collaborator

sarahcn commented Jun 1, 2018

Submission guide states that DS can be in either .txt or .xlsx input format - I had misread that initially and was only allowing for .txt input
maybe it's possible to have just one 'read' function that has an argument for dd=TRUE or dd=FALSE (where dd=FALSE means it's read in as a DS file)

@broomej
Copy link
Collaborator

broomej commented Jan 28, 2020

I'm assuming this is about read_ds_file() and read_dd_file(). Do changes need to be made elsewhere?

@broomej
Copy link
Collaborator

broomej commented Jan 29, 2020

I just noticed that dd = TRUE is an argument for read_ds_file(). Do we want to use read_ds_file() to read datasets and data dictionaries, and depricate read_dd_files?

The alternative I can think of is to leave both functions, but have them as a wrapper for more flexible function (maybe exported, maybe not, I'm not sure) that takes the dd argument. This seems maybe a little more convoluted than necessary

@smgogarten
Copy link
Contributor

read_dd_file calls read_ds_file(dd=TRUE), so read_ds_file is already the base function.

@broomej broomej self-assigned this Feb 19, 2020
@broomej broomej removed their assignment Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants