Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitNullModel doesn't converge when provided a list of matrices with more than 1 matrix #91

Open
tamartsi opened this issue May 5, 2022 · 3 comments

Comments

@tamartsi
Copy link
Contributor

tamartsi commented May 5, 2022

fitNullModel doesn't converge when provided a list of matrices with more than 1 matrix. We tried providing one matrix, and it was fine, we tried providing a list of a single matrix, and it was fine (converged). It seems like there is an issue with more than one matrix. I haven't looked at the code.

@smgogarten
Copy link
Collaborator

We have a unit test for multiple matrices, so it does run with a trivial example. Unfortunately that means the issue is more difficult to solve since it's related to the specifics of the data.

@tamartsi
Copy link
Contributor Author

tamartsi commented May 5, 2022

Hmmm. The fitNullModel function did work using an earlier version of GENESIS, so I don't think this is the data. Could it be related to the type of outcome? we looked at it today with a binary outcome (family = "binomial").

@mconomos
Copy link
Contributor

mconomos commented May 5, 2022

Do you have a log you can share? It certainly has worked with multiple matrices in the past, and I don't think we've made any changes that would have affected this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants