Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitted.values in non-mixed null models are not what we expect #86

Open
amstilp opened this issue Feb 18, 2022 · 0 comments
Open

fitted.values in non-mixed null models are not what we expect #86

amstilp opened this issue Feb 18, 2022 · 0 comments

Comments

@amstilp
Copy link
Contributor

amstilp commented Feb 18, 2022

The fitted.values element of null models is different for non-mixed models and mixed-models. This had caused errors in SPA p-values for models without variance components or where variance components were estimated to be 0 (see #84).

Consider a bigger fix to make fitted.values consistent for all types of null model (e.g., it is always the same thing) but that is a much more involved change and has some issues with backwards compatibility (e.g., using a version of the null model run with an older version of GENESIS to do Score.SPA association tests in a new version).

Originally posted by @amstilp in #84 (comment)

@amstilp amstilp changed the title fitted.values in glm null models are not what we expect fitted.values in non-mixed null models are not what we expect Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant