Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsible Mobile RHS #334

Merged
merged 11 commits into from
Jan 5, 2025
Merged

Collapsible Mobile RHS #334

merged 11 commits into from
Jan 5, 2025

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Nov 25, 2024

Resolves #274

@TyHil TyHil linked an issue Nov 25, 2024 that may be closed by this pull request
[Feature Request] Mobile UI #274
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 11:24pm

@TyHil TyHil mentioned this pull request Nov 25, 2024
Closed
@AbhiramTadepalli AbhiramTadepalli marked this pull request as ready for review November 27, 2024 14:12
@AbhiramTadepalli AbhiramTadepalli self-requested a review as a code owner November 27, 2024 14:12
AbhiramTadepalli
AbhiramTadepalli approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@AbhiramTadepalli AbhiramTadepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So open is always true when the screen is wide?

Do you have to change useMediaQuery?

@TyHil
Copy link
Member Author

TyHil commented Nov 27, 2024

So open is always true when the screen is wide?

Yes

Do you have to change useMediaQuery?

Yeah I should do that

@TyHil
Copy link
Member Author

TyHil commented Nov 27, 2024

I think I'll need #332 merged in to see how these work together before I can get rid of the second useMediaQuery

@TyHil TyHil merged commit dac5f04 into develop Jan 5, 2025
3 checks passed
@TyHil TyHil deleted the mobile-rhs branch January 5, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiramTadepalli AbhiramTadepalli AbhiramTadepalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Mobile UI
2 participants
@TyHil @AbhiramTadepalli