Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Change xr.ufuncs.log to np.log, edits to use of log #213

Open
jds485 opened this issue Mar 17, 2023 · 0 comments
Open

Change xr.ufuncs.log to np.log, edits to use of log #213

jds485 opened this issue Mar 17, 2023 · 0 comments

Comments

@jds485
Copy link
Member

jds485 commented Mar 17, 2023

I tried using the log target variable option and found that xr.ufuncs.log is now outdated and we should switch to np.log, as documented here:

Line to change.

Also, I think the val and tst data need to be logged here. Why are only the training data logged? The mean and standard deviation are computed on the logged data and then applied to the val and tst data, which are not logged. Some comments in the preproc_utils need to be updated to describe what log_y_vars and log_vars should be.

And we should subtract off the small constant after transforming from log to real space here.

I can address these edits in a PR

@jds485 jds485 changed the title Change xr.ufuncs.log to np.log Change xr.ufuncs.log to np.log, edits to use of log Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant