Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

linalg method of gw loss gives erroneous values with pytorch #172

Open
janetrbarclay opened this issue Feb 10, 2022 · 0 comments
Open

linalg method of gw loss gives erroneous values with pytorch #172

janetrbarclay opened this issue Feb 10, 2022 · 0 comments

Comments

@janetrbarclay
Copy link
Collaborator

Using the linear algebra calculation approach for the groundwater loss in pytorch gives values 2 to 10 times higher than the loss values using the fft calculation within pytorch, the fft calculation within tf and the linear algebra calculation within tf (these three are the same).

We've added an assertion that requires the fft method when the gw loss is used within pytorch. We are not debugging the linear algebra code, but are leaving it for now in case it is needed in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant