Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Simplify training routine #146

Closed
jsadler2 opened this issue Nov 16, 2021 · 2 comments · Fixed by #148
Closed

Simplify training routine #146

jsadler2 opened this issue Nov 16, 2021 · 2 comments · Fixed by #148

Comments

@jsadler2
Copy link
Collaborator

@SimonTopp made some improvements to the modularity of the training routine, and that got me thinking that it could be even simpler.

I'm thinking that we could just have basically the following parameters to the train function:

  • compiled model
  • x train
  • x validation (optionally)
  • y train
  • y validation (optionally)
  • other training parameters like we already have (epochs, early stop, out_dir, etc.)

Then all the other logic could go in the Snakefile including:

Feel free to share thoughts here or it maybe clearer what I'm trying to do in the coming PR.

@SimonTopp
Copy link
Contributor

SimonTopp commented Nov 17, 2021

I like the way you're heading with this, I think it would also potentially translate down the road to a model agnostic repository that's a little more generalizable. Since it's come up a few times, I might add fixing the discontinuous sequences in #127 to the same update.

@jsadler2
Copy link
Collaborator Author

I definitely think that #127 needs to be addressed, but I don't think it should be in this PR. I think our PRs should be able to be described in one line and have only one idea. This makes it easy to understand what we are trying to accomplish in any given PR at a glance. It also makes it clear when looking back in the git history what exactly a given PR was about. So I'm in favor of a 1) "simplify training routine" PR and 2) a separate "address non-continuous training sequences" PR, especially since they are independent components of the workflow.

jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 1, 2021
rm trainer class, model as input, files as input
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 1, 2021
this is to accommodate new train routine
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 1, 2021
also found bug in not passing spatial/time idx names all the way through
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 3, 2021
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 30, 2021
Also converted "trainer" class to more generic function
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Dec 30, 2021
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 19, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
rm trainer class, model as input, files as input
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
this is to accommodate new train routine
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
also found bug in not passing spatial/time idx names all the way through
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 20, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
jsadler2 added a commit to jsadler2/river-dl that referenced this issue Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants