Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When should a DAG Run fail? #50

Open
7yl4r opened this issue May 8, 2018 · 1 comment
Open

When should a DAG Run fail? #50

7yl4r opened this issue May 8, 2018 · 1 comment
Labels
question

Comments

@7yl4r
Copy link
Member

7yl4r commented May 8, 2018 •
edited
Loading

There are times when a DAG will appear successful even when it did not run as expected:

  1. FileTriggerDAGs are successful if they catch the error and mark the product in the db as "error"
  2. DAGs using imars-etl succeed if they are able to cleanup tmp files following a failure.

On one hand, these DAGs did succeed in catching the errors and handling them, on the other hand these are obviously not 100% successful DAG attempts (since they have errors).
@7yl4r 7yl4r added the question label May 8, 2018
@7yl4r
Copy link
Member Author

7yl4r commented May 13, 2018

See... like why are these DAGRuns "success" and not "fail"? I guess it is because the "leaves" of the DAG are "skipped" and not "failed"?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@7yl4r