enforce formatting of C++ code #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 576f925.
|
@cwsimmon could you mark as accepted if you're ok w/ the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using clang-format, enforce styling and formatting of bmdscore source code.
To run, you'll need to install a specific version of clang-format, the easiest way I found fo reproducible installation was a python wrapper, https://pypi.org/project/clang-format/19.1.3/.
Then, you can run the make command
make format-cpp. We run this in CI/CD and checks that the git diff is clean to ensure code is properly formatted.I added a basic
.clang-formatfile, but that could be modified to make the code look more to our personal preferences.I did have to make a few manual edits to get the code to compile again after running the formatter, 702b73,