Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 403 for TimeSeries on Public Instance #972

Open
krowvin opened this issue Dec 10, 2024 · 0 comments
Open

Return 403 for TimeSeries on Public Instance #972

krowvin opened this issue Dec 10, 2024 · 0 comments
Labels
discussion-point Something to talk about but take no action yet enhancement New feature or request Security Issue related to security in some way

Comments

@krowvin
Copy link
Collaborator

krowvin commented Dec 10, 2024

We had talked about the various ways the TimeSeries are handled with filtering.

Currently there exists a flag that is set by districts in CMA to handle this. Then in the SQL package retrieve_ts (i believe) handles what gets returned.

I propose if a TS flag is set to not return various TS that instead of returning an empty TS response we instead return a JSON response with a 403 status code. There might even be null values with dates returned even if the TSID is not listed.

This could also be expanded to the catalog although not sure how involved that could be.

Something like:

{
  "message": "TimeSeries ID is disabled due to filtering"
}

..more? Perhaps consider empty values array and other usual params here for backwards compatability

This is more explicit and helps districts understand why.

One current gotcha with the existing architecture

Districts would continue to expect internal access to all TimeSeries on their T7 CDA instance. So perhaps this rule only applies to "/cwms-data/" until future work has been done?

@MikeNeilson MikeNeilson added enhancement New feature or request discussion-point Something to talk about but take no action yet Security Issue related to security in some way labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-point Something to talk about but take no action yet enhancement New feature or request Security Issue related to security in some way
Projects
Status: No status
Development

No branches or pull requests

2 participants