[Enhancement]: Not obvious that data beyond timewindow will download when selecting forecasted data

[msweier]

Describe the bug

Cumulus website is not intuitive when downloading forecasted data beyond current day. The current date can be selected through 11:30 pm as an end date, but data beyond current date is downloaded.

Steps To Reproduce

1. Go to a forecasted product
2. Click on Download Selection
3. End date won't extend beyond current day.

Expected behavior

Timewindow would select the data time, not the acquisition time.

Actual behavior

Timewindow appears to select acquisition time or similar.

Screenshots

[adamscarberry]

Here is the challenge. When the CAVI extracts from a date range, the products are usually both observed data and forecast data. No one wants to select the exact forecast version they want, so we grab that that two versions based on the selected end date (in case the last one is not complete - if the last one is complete it will override all records in the dss file) based on the selected end date.

If your end date is 19-July in the above example, you will get data products for the future (based on your end date).

I can't remember all the date options in the CAVI for the time window of the simulation, but this approach made the most sense when trying to satisfy both the observed data and forecast data.

We would rather err on the side of more data than less data (than what was expected). If we capped your forecast files based on an end date, you wouldn't get the full forecast.

[adamscarberry]

Additional details here for how the timewindow is handled by the view for download requests:

https://github.com/USACE/cumulus-api/blob/81b6be0846d9da8a13eb3f2d79a8ee6c9d1bd64e/sql/common/R__05_views_downloads.sql#L91-L98