Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODUCT] APRFC data products #380

Closed
1 of 4 tasks
Enovotny opened this issue Oct 20, 2023 · 8 comments · Fixed by USACE/cumulus-geoproc-test-data#21, USACE/cumulus-geoproc#50 or USACE/cumulus-api#516
Closed
1 of 4 tasks
Assignees

Comments

@Enovotny
Copy link

Enovotny commented Oct 20, 2023

Product Source (URL Preferred)

https://cbt.crohms.org/akgrids/

Product Description

ABRFC QPF, QPE, QTE, QTF

Product Format

  • Geotiff
  • Grib2
  • NetCDF
  • Other (Please provide description below)

Format Description

APRFC Forcings for USACE (1).docx

@adamscarberry
Copy link
Contributor

ABRFC QPF, QPE deployed to stable. Thanks to @Enovotny for working on the migrations and processors.

@adamscarberry adamscarberry changed the title APRFC data products: [PRODUCT] APRFC data products Nov 29, 2023
@msweier msweier self-assigned this Jun 24, 2024
@FHanbali
Copy link
Contributor

FHanbali commented Jul 9, 2024

QPE and QPF values are suspicious, showing 60+ inches for a one week time window
APRFC_WrongValues

Suspect mm to inches conversion maybe the issue.

@adamscarberry
Copy link
Contributor

Fix by @msweier deployed to stable. This can be closed if @FHanbali will test the downloaded results again.

@FHanbali
Copy link
Contributor

FHanbali commented Aug 15, 2024

@msweier I'm still seeing large precip values. I cross checked a download from cumulus for a forecast starting at 09August2024-1200 against original grib files (which have "mm" units). It seems that Cumulus is not converting from "mm" to "inches" properly.

Btw, the DSS download from Cumulus has units of "inches" for the DSS records, but I'm pretty sure the values have not truly been converted to inches. Suggest writing out the records with units of "mm" anyway, that way you wouldn't have to worry about unit conversions.

@adamscarberry I'm curious if all the products in Cumulus are getting unit conversions?

@FHanbali
Copy link
Contributor

Here are the test Cumulus download and original APRFC files
APRFC_QPF_Tests.zip

@FHanbali
Copy link
Contributor

Also wanted to verify, once a fix is complete for this, will the entire archive for this product in Cumulus get corrected please?

@adamscarberry
Copy link
Contributor

We do not convert units as it goes from raw product to geotif (done by async_geoprocessor). Original units should remain.

The fix attempted by @msweier was to change the units for the product in the database which the async_packager uses to create the dss download.

No files should need reprocessed. Once fixed the future downloads should e correct.

I'm not able to look deeper into this issue right now.

@msweier
Copy link

msweier commented Aug 16, 2024

@msweier I'm still seeing large precip values. I cross checked a download from cumulus for a forecast starting at 09August2024-1200 against original grib files (which have "mm" units). It seems that Cumulus is not converting from "mm" to "inches" properly.

Btw, the DSS download from Cumulus has units of "inches" for the DSS records, but I'm pretty sure the values have not truly been converted to inches. Suggest writing out the records with units of "mm" anyway, that way you wouldn't have to worry about unit conversions.

@adamscarberry I'm curious if all the products in Cumulus are getting unit conversions?

Thanks for the test data @FHanbali. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants