Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate and confusing msgid's in translation files make it hard to help translating #2001

Open
eltomato89 opened this issue Oct 23, 2023 · 3 comments
Assignees

Comments

@eltomato89
Copy link
Contributor

I think that the I18N implementation needs some rework.

The .po files do contain multiple duplicate entries like:

(ref: /ravada/lib/Ravada/I18N/de.po)

Line 152: "Shutdown", Line 1702: "Shutdown"
Line 883: "Save", Line 1660: "Save"
Line 116: "New Password", Line 1429: "New Password"

Sometimes they are also quite confusing like:

Line 1666: "Schedule".
Schedule like in "(to) Schedule something"? Or more like "A Schedule"?

Right now, it is really hard to help translating the software, without looking up every reference in code. (Which makes no sense when dealing with 2000 lines of translations)

@frankiejol
Copy link
Member

You are right @eltomato89 strings were added as they were needed without much care.
First of all I see there are duplicated strings with mixed upper and lower cases. We will try to identify them to try to fix it when possible.
Then there is the problem about knowing the proper meaning by the context. I don't see an easy way to address it, maybe we could add some comments before the strings.

@frankiejol frankiejol self-assigned this Oct 24, 2023
@eltomato89
Copy link
Contributor Author

Yes, that comments would be a great start.
Also, it seems that strings are broken up into multiple msgids, which makes it hard to get the meaning while just looking on the translation files.

Maybe its better to use placeholders or sprintf?

frankiejol added a commit that referenced this issue Oct 24, 2023
@frankiejol
Copy link
Member

Actually the strings are in HTML templates. Code like sprintf could be added but I don't know how to use them with the po localization files. Could you give an example about the placeholders ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants