Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing URL files when HQ jobs are cancelled #47

Open
Schlevidon opened this issue Jan 21, 2024 · 1 comment
Open

Removing URL files when HQ jobs are cancelled #47

Schlevidon opened this issue Jan 21, 2024 · 1 comment

Comments

@Schlevidon
Copy link
Collaborator

After #45 all old URL files are removed when starting the load balancer. Should we still remove the URL file whenever a HQ job is cancelled?

  • Not removing the files might be helpful for debugging and keeping them wouldn't clutter the system too much, since they get deleted before each run anyways.
  • If we decide to keep the current behavior, the code should be refactored to use the std::filesystem library instead of plain bash.

std::system(("rm ./urls/url-" + job_id + ".txt").c_str());

@linusseelinger
Copy link
Member

I think we should still delete the url files after use. There might be millions of runs, so at some point the file system may become unhappy. We might think about some kind of verbose/debug output mode though if problems turn out frequent in practice.
Good point about std::filesystem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants