Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M for Mode, depricating Z for Zombie #3

Open
oddstr13 opened this issue Sep 2, 2016 · 6 comments
Open

M for Mode, depricating Z for Zombie #3

oddstr13 opened this issue Sep 2, 2016 · 6 comments

Comments

@oddstr13
Copy link

oddstr13 commented Sep 2, 2016

I suggest using the M character as a replacement for Z, allowing for more different states to be transmitted.

Lost in the conversion from the wiki;

Query: should Zombie be deprecated in favor of Mode as per https://oddstr13.openshell.no/paste/VwWOq8-1/

  • repeating packets? Repeater
  • uploading packets? Gateway
  • operating in a low-power mode? Zombie
  • getting location from GPS (or possibly wifi)? Location up to date
  • moving? vehicle? by sea, air or road?
  • APRS? GSM?
@philcrump
Copy link
Member

I'm in favour of deprecating 'Zombie', we need a rough (optional) spec for the Mode values first though.

@jamescoxon
Copy link
Member

Mode does make more sense and having a number of different values is a good idea.

We probably can't reassign Z though as a number of nodes will continue to use it. Obviously will try and update them but quite a few are hard to get to.

@russss
Copy link
Collaborator

russss commented Sep 4, 2016

If we were going to munge all of these attributes into one field then we could use a bitmask. The problem with that is it isn't possible to parse in grafana. That said, I think any method of doing this is going to require some additional parsing on the grafana inserter.

If we were happy to sacrifice a byte or two and have a slightly differently-formatted field, we could assign a (lowercase) letter to each of these statuses. So you could have Mrg for a repeater and a gateway. I think it's usually unlikely you'll have more than one or two of these status letters, and this makes it more human-readable.

"Zombie mode" is really just "not a repeater" so it probably doesn't need a letter by itself.

My solarnodes use an X field to communicate battery charge status, so we could also have a "charging" and "charged" status.

@philcrump
Copy link
Member

+1 for the lowercase letter flags!

@oddstr13
Copy link
Author

oddstr13 commented Sep 6, 2016

@russss I somewhat disagree on the point about zombie mode. Zombie mode means that the node isn't even listening for packets, and that it probably is doing some deep sleep between sending packets. A node could be made to listen for packets, while not repeating them. It could still be acting on the received packets.
Indicating zombie state could be useful in the case of a normally zombie mode node occasionally (say, between sequence a-c for example) waking up and listening, for configuration purposes or some such.

@philcrump
Copy link
Member

Well in that case, listening for command packets would be a candidate for a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants