Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPU master thread dispatches one request at a time near the end of long files #2

Open
andradazoltan opened this issue Jan 6, 2021 · 0 comments
Labels
bug Something isn't working high priority

Comments

@andradazoltan
Copy link
Collaborator

Priority: high

At the start of the program, the DPU master thread correctly dispatches multiple requests at a time. The size of each batch largely depends on how many upper-level threads are in the ORC parser, and should be close to that number. However, towards the end of the program the upper-level threads appear to get out of sync, resulting the the DPU master thread only dispatching one request at a time.

To observe this bug add two print statements:

  • One in load_rank after each request's initial information is copied to the DPU
  • One in unload_rank after each request's ID is copied back from the DPU

Towards the start of the program, the prints will appear as a batch of "load" followed by a batch of "unload", as desired. Towards the end of the program, the prints will appear as one "load" followed by one "unload" and so on.

This needs to be fixed in hopes of achieving an efficient implementation. It may require some updates to the scheduling policy to prevent it from getting into this state, or recover if it ever gets into this state.

@andradazoltan andradazoltan added bug Something isn't working high priority labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

No branches or pull requests

1 participant