Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict between variables #4

Open
jnider opened this issue Oct 23, 2020 · 1 comment
Open

Conflict between variables #4

jnider opened this issue Oct 23, 2020 · 1 comment

Comments

@jnider
Copy link

jnider commented Oct 23, 2020

__mram_noinit uint64_t index_len_input;

You have a static definition of MAX_SIZE, but you allow index_len to be passed in as a parameter without limiting its size. This may cause an overflow of read_buf.

@nzarif
Copy link
Collaborator

nzarif commented Oct 28, 2020

So you mean I should check and make sure this Len is smaller than MAX_SIZE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants