Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constant value instead of dynamic value #15

Open
jnider opened this issue Dec 11, 2020 · 0 comments
Open

constant value instead of dynamic value #15

jnider opened this issue Dec 11, 2020 · 0 comments

Comments

@jnider
Copy link

jnider commented Dec 11, 2020 •
edited
Loading

PIM-Embedding-Lookup/upmem/include/emb_types.h

Line 7 in 8c96b12

#define AVAILABLE_RANKS 10

You don't know how many ranks will be available. Making an assumption like this can lead to difficult bugs. You should use dpu_get_nr_ranks() and dpu_get_nr_dpus() where necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnider