-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread titles with invalid characters in Windows export with MS-DOS like names #1275
Comments
Can you provide examples of the actual thread names? |
And many more, all of them seem to have invalid characters for windows filenames. Also somewhat strange is the files have no extension when exported. Many of these threads are from a forum channel where anyone can open a request and so they aren't that important, but it's annoying and if this is wider spread than just me, I can see how it might be a bigger issue. |
I was not able to reproduce this issue. I created a thread entitled It might be a Unix-specific issue. Can you upload the files that you experienced the issue with? |
Hmm. I just tested it again with a single channel export, and it worked. I'll try to redo the export I guess? This was a large server so it will most likely take a few days to export again. This is one of the files that exhibits the issue from an export I did in August. I added the file extension since macOS threw a fit at trying to zip it (guess certain implementations of zip don't like tilde?) and GitHub doesn't support extensionless files. Only other thing I can think is that somehow the filenames are handled differently between the single channel export and exporting an entire server with threads. I'm not super familiar with C# but I'll see if I can find anything in the code. |
@DannyDorito24 did it work on your second attempt? |
The forum channel errors are unrelated and can be safely ignored if you're doing Are you still getting truncated thread names? |
Yes, I've attached a few of them if it helps, but there's nothing obvious in the files to me other than the names. |
Hmm, can you share a server invite link? I can't reproduce it with threads on my own |
Yep, it's Minecraft@Home, https://discord.gg/xArErFf |
Version
2.43.3
Flavor
CLI (Command-Line Interface)
Platform
Ubuntu/MacOS
Export format
JSON
Steps to reproduce
Create threads with illegal filename characters (i.e. ? " / | : etc), export them, and threads containing those characters in their names will end up with 8 character names with a ~ character in them, much like old truncated MS-DOS names. (Example image attached)
Details
I don't think this is a duplicate, but it's possible my search was incomplete as I'm not really sure how to describe the issue.
The most logical way to fix this, as I see it, would be to simply strip the illegal characters out of the filename. While not ideal, I imagine this is a limitation of .NET even on systems that support these characters (macOS and most Linux distros). Currently it is not ideal to browse through threads with names like this due to the fact that the truncated names don't seem to relate at all to what they were supposed to be named.
Example from a recent export I did of a large server:
Oddly, .NET does not throw any error or warning related to this, so the diagnosis here is of my own deduction. This has happened for many versions now, for me at least, so while I assume it's something in .NET, I'm somewhat confused as to why it hasn't been reported before if this is truly not a duplicate issue. Perhaps it's something else in the chain, but this happens on multiple systems.
Checklist
The text was updated successfully, but these errors were encountered: