Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with the latest wrapper beta #788

Open
cdietrich opened this issue Nov 22, 2024 · 10 comments
Open

Problem with the latest wrapper beta #788

cdietrich opened this issue Nov 22, 2024 · 10 comments

Comments

@cdietrich
Copy link
Contributor

cdietrich commented Nov 22, 2024

hi,

after updating to next.7 and vscode-api 11.1.1

am getting this from the bundler

> @everestsystems/[email protected] build
> tsc --noEmit -p ./tsconfig.json && node build.mjs

✘ [ERROR] Could not resolve "@codingame/monaco-vscode-chat-extensions-notebook-task-terminal-testing-common/vscode/vs/workbench/contrib/terminal/common/terminal"

    ../../node_modules/vscode/vscode/src/vs/workbench/contrib/terminal/common/terminalContextKey.js:3:33:
      3 │ import { TERMINAL_VIEW_ID } from '@codingame/monaco-vscode-chat-extensions-notebook-task-terminal-testing-common/vscode/vs/workbench/contrib/terminal/common/termin...
        ╵                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

in my transitives (yarn.lock" i can see @codingame/monaco-vscode-chat-extensions-notebook-common only

@cdietrich
Copy link
Contributor Author

grafik

@cdietrich
Copy link
Contributor Author

maybe this is not a dev dependency after all

@kaisalmen
Copy link
Collaborator

kaisalmen commented Nov 22, 2024

@cdietrich you are talking about -next.8, right? The root cause needs to be fixed by @CGNonofr . WA: is to add it as dependency.
Verification examples are broken as well. Our production build works, though. I need to release a -next.9

@cdietrich
Copy link
Contributor Author

cdietrich commented Nov 22, 2024

afff yes

"monaco-editor-wrapper": "6.0.0-next.8",
"monaco-languageclient": "9.0.0-next.8",

@kaisalmen
Copy link
Collaborator

Verification builds are running, but I did not need to add the above dependency. Let's see what happens in the pipeline:
https://github.com/TypeFox/monaco-languageclient/actions/runs/11972730661/job/33380237247

@kaisalmen
Copy link
Collaborator

Oh boy, my computer has Friday. 🙈 I don't see the errors locally. ⬆️

@kaisalmen
Copy link
Collaborator

Will add dependency there first and if that works, add it to the wrapper as WA and release new versions.

@kaisalmen
Copy link
Collaborator

Reminder to myself: Always remove package-lock file and node_modules if you want to start fresh (npm run reset:repo exists for a reason)

@kaisalmen
Copy link
Collaborator

kaisalmen commented Nov 22, 2024

@cdietrich -next.9 versions are available. Verification build is still running, but looking good, so far:
https://github.com/TypeFox/monaco-languageclient/actions/runs/11973325975/job/33382171130

@kaisalmen
Copy link
Collaborator

@cdietrich workaround is in place and works (verification is ✅ again). We will keep this issue open until the root cause is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants