Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mode=None to keep current mode? #331

Open
ego-thales opened this issue Nov 7, 2024 · 1 comment · May be fixed by #337
Open

Allow mode=None to keep current mode? #331

ego-thales opened this issue Nov 7, 2024 · 1 comment · May be fixed by #337

Comments

@ego-thales
Copy link

ego-thales commented Nov 7, 2024 •
edited
Loading

Currently, it seems that torchinfo forces the user to choose between eval or train mode. Couldn't we allow mode=None to simply not modify current mode?
@TylerYep
Copy link
Owner

This seems reasonable. I'll accept a PR making this change.

ego-thales added a commit to ego-thales/torchinfo-pr that referenced this issue Nov 29, 2024
@ego-thales
api: summary keeps current mode (TylerYep#331)
ac27457
@ego-thales ego-thales linked a pull request Nov 29, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: summary mode=None keeps current mode (#331) ego-thales/torchinfo-pr
2 participants
@TylerYep @ego-thales